[alsa-devel] TerraTec DMX 6Fire USB updates
tiwai at suse.de
Fri Apr 1 14:52:50 CEST 2011
At Thu, 31 Mar 2011 21:25:23 +0200,
Torsten Schenk wrote:
> Hello everyone,
> The driver I wrote for the 6fire usb is now in use by some people so that I got feedback. This enabled me to improve and bugfix some things. Here the patch.
Could you give a bit more information, what does your patch fix exactly?
This must be written in the changelog.
> +static int usb6fire_control_digital_thru_info(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_info *uinfo)
> + uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
> + uinfo->count = 1;
> + uinfo->value.integer.min = 0;
> + uinfo->value.integer.max = 1;
> + return 0;
Use the common snd_ctl_boolean_mono_info() instead.
> +/* check, if the firmware version the devices has currently loaded
> + * is known by this driver. 'version' needs to have 4 bytes version
> + * info data. */
> +static int usb6fire_fw_check(u8 *version)
> + int i;
> + for (i = 0; i < ARRAY_SIZE(known_fw_versions); i++)
> + if (!memcmp(version, known_fw_versions, 4))
No increment or indexing (although there is only one element for now)?
More information about the Alsa-devel