feat: enhance lord's decision-making with action probabilities and personality traits

src/unpredictable_lord/game_state.py

@@ -236,16 +236,11 @@ ACTION_EFFECTS: dict[str, dict[str, int]] = {
     "do_nothing": {},
 }
 
-# Alternative actions when lord rejects advice
-REJECTION_ALTERNATIVES = {
-    "increase_tax": ["do_nothing", "improve_diplomacy"],
-    "decrease_tax": ["do_nothing", "increase_tax"],
-    "expand_territory": ["do_nothing", "improve_diplomacy"],
-    "improve_diplomacy": ["do_nothing", "public_festival"],
-    "public_festival": ["do_nothing", "improve_diplomacy"],
-    "build_infrastructure": ["do_nothing", "improve_diplomacy"],
-    "do_nothing": ["do_nothing"],  # Always accept do_nothing
-}
+# All possible actions (derived from ACTION_EFFECTS keys)
+ALL_ACTIONS: list[str] = list(ACTION_EFFECTS.keys())
+
+# Probability that lord chooses a preferred action when rejecting advice
+PREFERRED_ACTION_PROBABILITY = 0.7
 
 
 def _calculate_acceptance(state: "GameState", advice: str) -> tuple[bool, str, str]:
@@ -285,11 +280,36 @@ def _calculate_acceptance(state: "GameState", advice: str) -> tuple[bool, str, s
             f"{ADVICE_DESCRIPTIONS[advice]['name']}."
         )
     else:
-        # Lord rejects and takes alternative action
-        alternatives = REJECTION_ALTERNATIVES.get(advice, ["do_nothing"])
-        action_taken = random.choice(alternatives)
-        if action_taken == advice:
+        # Lord rejects and takes alternative action based on personality
+        # Exclude: the original advice and disliked actions
+        excluded_actions = {advice} | set(traits["disliked"])
+        available_actions = [a for a in ALL_ACTIONS if a not in excluded_actions]
+
+        # If no actions available (edge case), fall back to do_nothing
+        if not available_actions:
             action_taken = "do_nothing"
+        else:
+            # High probability: choose from preferred actions
+            # Low probability: choose from other available actions
+            preferred_available = [
+                a for a in traits["preferred"] if a not in excluded_actions
+            ]
+
+            if preferred_available and random.random() < PREFERRED_ACTION_PROBABILITY:
+                action_taken = random.choice(preferred_available)
+            else:
+                # Choose from non-preferred available actions
+                non_preferred = [
+                    a for a in available_actions if a not in traits["preferred"]
+                ]
+                if non_preferred:
+                    action_taken = random.choice(non_preferred)
+                elif preferred_available:
+                    # All available actions are preferred, pick from preferred
+                    action_taken = random.choice(preferred_available)
+                else:
+                    action_taken = "do_nothing"
+
         adoption_message = (
             f"The lord has rejected your advice ({ADVICE_DESCRIPTIONS[advice]['name']}) "
             f"and instead chose: {ADVICE_DESCRIPTIONS[action_taken]['name']}."