|To:||Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>|
|Subject:||Re: [PATCH] forcedeth: fix random memory scribbling bug|
|From:||Jeff Garzik <jgarzik@xxxxxxxxx>|
|Date:||Sat, 24 Dec 2005 10:09:31 -0500|
|Cc:||Linus Torvalds <torvalds@xxxxxxxx>, Ayaz Abdulla <AAbdulla@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>|
|User-agent:||Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)|
Manfred Spraul wrote:
Two critical bugs were found in forcedeth 0.47: - TSO doesn't work.- pci_map_single() for the rx buffers is called with size==0. This bug is critical, it causes random memory corruptions on systems with an iommu.Below is a minimal fix for both bugs, for inclusion into 2.6.15. TSO will be fixed properly in the next version. Tested on x86-64. Signed-Off-By: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
1) Why does forcedeth require a non-standard calculation for each pci_map_single() call?
2) I have requested multiple times that you avoid MIME...3) Why disable TSO completely? It sounds like it should default to off, then permit enabling via ethtool.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||[PATCH] forcedeth: fix random memory scribbling bug, Manfred Spraul|
|Next by Date:||Re: [PATCH] forcedeth: fix random memory scribbling bug, Manfred Spraul|
|Previous by Thread:||[PATCH] forcedeth: fix random memory scribbling bug, Manfred Spraul|
|Next by Thread:||Re: [PATCH] forcedeth: fix random memory scribbling bug, Manfred Spraul|
|Indexes:||[Date] [Thread] [Top] [All Lists]|