preparing pcf50633 for upstream
balaji at raobalaji.com
Thu Oct 2 03:30:59 CEST 2008
On Wed, 01 Oct 2008 20:51:51 +0100
Andy Green <andy at openmoko.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Somebody in the thread at some point said:
> |> This is pcf50633_get_power_status? It does a pcf50633 register
> read |> in there. Or is it something else?
> | Yes, but it needs pc50633_global. I was thinking if we could change
> Got your point now, see the problem.
> | pcf50633_get_power_status to take a struct pcf50633_data. This
> would be | function to report power status in "apm style". And the
> | apm_get_power_status callback itself could reside in mach_gta02.c
> It sounds right about the callback in mach_gta02.c because in
> ./include/linux/apm-emulation.h it does say about struct
> ''* This structure gets filled in by the machine specific
> 'get_power_status' ~ * implementation. Any fields which are not set
> default to a safe value.''
> But I didn't quite see the idea about delivering struct pcf50633_data
> * to the pcf50633_get_power from mach_gta02.c without a global
mach-gta02.c knows about the pcf50633 it contains anyway. So, it's
fine to have a global there.
More information about the openmoko-kernel