[PATCH 1/5] win16/int21: make found filename uppercase.
bug-track at fisher-privat.net
Thu May 31 03:30:31 CDT 2012
Am 30.05.2012 23:06, schrieb David Laight:
> On Wed, May 30, 2012 at 01:32:28PM +0200, Alexandre Julliard wrote:
>> Oleksij Rempel <bug-track at fisher-privat.net> writes:
>>> @@ -3961,6 +3962,8 @@ static int INT21_FindNext( CONTEXT *context )
>>> INT21_FindPath = dta->fullPath = NULL;
>>> dta->count = n;
>>> + p = dta->filename;
>>> + for ( ; *p; p++) *p = toupper(*p);
>> Using toupper is probably not a good idea on OEM codepage strings. Which
>> app depends on this?
> I'd also guess that 'p' is defined as 'char *'.
> The domain of toupper() isn't char, the value must be cast to
> 'unsigned char' (or the pointer to 'unsigned char *').
it is true, i used "char *". I just copy pasted this part from
"Convert ASCIIZ string to uppercase" in int21.c
So probably this should be fixed too.
Or there is any way no interest to apply current patch?
More information about the wine-devel