package coordinator

import (
	"context"
	"encoding/json"
	"sync"
	"testing"
	"time"

	"github.com/chroma-core/chroma/go/pkg/common"
	"github.com/chroma-core/chroma/go/pkg/proto/coordinatorpb"
	"github.com/chroma-core/chroma/go/pkg/sysdb/coordinator/model"
	"github.com/chroma-core/chroma/go/pkg/sysdb/metastore/db/dbmodel"
	"github.com/chroma-core/chroma/go/pkg/sysdb/metastore/db/dbmodel/mocks"
	"github.com/chroma-core/chroma/go/pkg/types"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/mock"
)

const (
	defaultTenant   = "default_tenant"
	defaultDatabase = "default_database"
)

func TestCatalog_CreateCollection(t *testing.T) {
	// create a mock transaction implementation
	mockTxImpl := &mocks.ITransaction{}

	// create a mock meta domain implementation
	mockMetaDomain := &mocks.IMetaDomain{}

	// create a new catalog instance
	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, nil, false)

	// create a mock collection
	metadata := model.NewCollectionMetadata[model.CollectionMetadataValueType]()
	metadata.Add("test_key", &model.CollectionMetadataValueStringType{Value: "test_value"})
	collection := &model.CreateCollection{
		ID:       types.MustParse("00000000-0000-0000-0000-000000000001"),
		Name:     "test_collection",
		Metadata: metadata,
		TenantID: "test_tenant",
	}

	// create a mock timestamp
	ts := types.Timestamp(1234567890)

	// mock the insert collection method
	name := "test_collection"
	mockTxImpl.On("Transaction", context.Background(), mock.Anything).Return(nil)
	mockMetaDomain.On("CollectionDb", context.Background()).Return(&mocks.ICollectionDb{})
	mockMetaDomain.CollectionDb(context.Background()).(*mocks.ICollectionDb).On("Insert", &dbmodel.Collection{
		ID:   "00000000-0000-0000-0000-000000000001",
		Name: &name,
		Ts:   ts,
	}).Return(nil)

	// mock the insert collection metadata method
	testKey := "test_key"
	testValue := "test_value"
	mockMetaDomain.On("CollectionMetadataDb", context.Background()).Return(&mocks.ICollectionMetadataDb{})
	mockMetaDomain.CollectionMetadataDb(context.Background()).(*mocks.ICollectionMetadataDb).On("Insert", []*dbmodel.CollectionMetadata{
		{
			CollectionID: "00000000-0000-0000-0000-000000000001",
			Key:          &testKey,
			StrValue:     &testValue,
			Ts:           ts,
		},
	}).Return(nil)

	// call the CreateCollection method
	_, _, err := catalog.CreateCollection(context.Background(), collection, ts)

	// assert that the method returned no error
	assert.NoError(t, err)

	// assert that the mock methods were called as expected
	mockMetaDomain.AssertExpectations(t)
}

func TestCatalog_GetCollections(t *testing.T) {
	// create a mock meta domain implementation
	mockMetaDomain := &mocks.IMetaDomain{}

	// create a new catalog instance
	catalog := NewTableCatalog(nil, mockMetaDomain, nil, false)

	// create a mock collection ID
	collectionID := types.MustParse("00000000-0000-0000-0000-000000000001")

	// create a mock collection name
	collectionName := "test_collection"

	// create a mock collection and metadata list
	now := time.Now()
	name := "test_collection"
	testKey := "test_key"
	testValue := "test_value"
	dbId := types.NewUniqueID()
	collectionConfigurationJsonStr := "{\"a\": \"param\", \"b\": \"param2\", \"3\": true}"
	collectionSchemaStr := "{\"a\": \"param\", \"b\": \"param2\", \"3\": true}"
	collectionAndMetadataList := []*dbmodel.CollectionAndMetadata{
		{
			Collection: &dbmodel.Collection{
				ID:                   "00000000-0000-0000-0000-000000000001",
				Name:                 &name,
				ConfigurationJsonStr: &collectionConfigurationJsonStr,
				SchemaStr:            &collectionSchemaStr,
				Ts:                   types.Timestamp(1234567890),
				DatabaseID:           dbId.String(),
				UpdatedAt:            now,
			},
			CollectionMetadata: []*dbmodel.CollectionMetadata{
				{
					CollectionID: "00000000-0000-0000-0000-000000000001",
					Key:          &testKey,
					StrValue:     &testValue,
					Ts:           types.Timestamp(1234567890),
				},
			},
		},
	}

	// mock the get collections method
	mockMetaDomain.On("CollectionDb", context.Background()).Return(&mocks.ICollectionDb{})
	var n *int32
	mockMetaDomain.CollectionDb(context.Background()).(*mocks.ICollectionDb).On("GetCollections", []string{*types.FromUniqueID(collectionID)}, &collectionName, common.DefaultTenant, common.DefaultDatabase, n, n, false).Return(collectionAndMetadataList, nil)

	// call the GetCollections method
	collections, err := catalog.GetCollections(context.Background(), []types.UniqueID{collectionID}, &collectionName, defaultTenant, defaultDatabase, nil, nil, false)

	// assert that the method returned no error
	assert.NoError(t, err)

	// assert that the collections were returned as expected
	metadata := model.NewCollectionMetadata[model.CollectionMetadataValueType]()
	metadata.Add("test_key", &model.CollectionMetadataValueStringType{Value: "test_value"})
	assert.Equal(t, []*model.Collection{
		{
			ID:                   types.MustParse("00000000-0000-0000-0000-000000000001"),
			Name:                 "test_collection",
			ConfigurationJsonStr: collectionConfigurationJsonStr,
			SchemaStr:            &collectionSchemaStr,
			Ts:                   types.Timestamp(1234567890),
			Metadata:             metadata,
			DatabaseId:           dbId,
			UpdatedAt:            now.Unix(),
		},
	}, collections)

	// assert that the mock methods were called as expected
	mockMetaDomain.AssertExpectations(t)
}

func TestCatalog_GetCollectionByResourceName(t *testing.T) {
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}

	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, nil, false)

	tenantID := "test_tenant"
	databaseID := types.NewUniqueID().String()
	tenantResourceName := "test_tenant_resource_name"
	collectionID := "00000000-0000-0000-0000-000000000001"
	collectionName := "test_collection"
	configurationJson := "{test_config}"
	schemaJson := "{test_schema}"
	dim := int32(128)

	mockCollectionEntry := &dbmodel.CollectionAndMetadata{
		Collection: &dbmodel.Collection{
			ID:                   collectionID,
			Name:                 &collectionName,
			ConfigurationJsonStr: &configurationJson,
			SchemaStr:            &schemaJson,
			Dimension:            &dim,
			DatabaseID:           databaseID,
			Ts:                   types.Timestamp(0),
			IsDeleted:            false,
			CreatedAt:            time.Now(),
			UpdatedAt:            time.Now(),
			Tenant:               tenantID,
		},
		CollectionMetadata: []*dbmodel.CollectionMetadata{},
		TenantID:           tenantID,
		DatabaseName:       "test_database",
	}

	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockCollectionDb.On("GetCollectionByResourceName", tenantResourceName, tenantID, databaseID).Return(mockCollectionEntry, nil)

	result, err := catalog.GetCollectionByResourceName(context.Background(), tenantResourceName, tenantID, databaseID)

	assert.NoError(t, err)
	assert.NotNil(t, result)
	assert.Equal(t, collectionID, result.ID.String())
	assert.Equal(t, collectionName, result.Name)
	assert.Equal(t, configurationJson, result.ConfigurationJsonStr)
	assert.Equal(t, &schemaJson, result.SchemaStr)
	assert.Equal(t, dim, *result.Dimension)
	assert.Equal(t, databaseID, result.DatabaseId.String())

	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
}

func TestCatalog_GetCollectionByResourceName_NotFound(t *testing.T) {
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}

	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, nil, false)

	tenantID := "test_tenant"
	databaseID := types.NewUniqueID().String()
	tenantResourceName := "non_existent_tenant_resource_name"

	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockCollectionDb.On("GetCollectionByResourceName", tenantResourceName, tenantID, databaseID).Return((*dbmodel.CollectionAndMetadata)(nil), nil)

	result, err := catalog.GetCollectionByResourceName(context.Background(), tenantResourceName, tenantID, databaseID)

	assert.Error(t, err)
	assert.Nil(t, result)

	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
}

func TestCatalog_GetCollectionByResourceName_DbError(t *testing.T) {
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}

	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, nil, false)

	tenantID := "test_tenant"
	databaseID := types.NewUniqueID().String()
	tenantResourceName := "test_tenant_resource_name"

	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockCollectionDb.On("GetCollectionByResourceName", tenantResourceName, tenantID, databaseID).Return((*dbmodel.CollectionAndMetadata)(nil), assert.AnError)

	result, err := catalog.GetCollectionByResourceName(context.Background(), tenantResourceName, tenantID, databaseID)

	assert.Error(t, err)
	assert.Equal(t, assert.AnError, err)
	assert.Nil(t, result)

	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
}

func TestCatalog_GetCollectionSize(t *testing.T) {
	mockMetaDomain := &mocks.IMetaDomain{}
	catalog := NewTableCatalog(nil, mockMetaDomain, nil, false)
	collectionID := types.MustParse("00000000-0000-0000-0000-000000000001")
	mockMetaDomain.On("CollectionDb", context.Background()).Return(&mocks.ICollectionDb{})
	var total_records_post_compaction uint64 = uint64(100)
	mockMetaDomain.CollectionDb(context.Background()).(*mocks.ICollectionDb).On("GetCollectionSize", *types.FromUniqueID(collectionID)).Return(total_records_post_compaction, nil)
	collection_size, err := catalog.GetCollectionSize(context.Background(), collectionID)

	assert.NoError(t, err)
	assert.Equal(t, total_records_post_compaction, collection_size)
	mockMetaDomain.AssertExpectations(t)
}

type mockS3MetaStore struct {
	mu           sync.RWMutex
	lineageFiles map[string]*coordinatorpb.CollectionLineageFile
	versionFiles map[string]*coordinatorpb.CollectionVersionFile
}

func newMockS3MetaStore() *mockS3MetaStore {
	return &mockS3MetaStore{
		versionFiles: make(map[string]*coordinatorpb.CollectionVersionFile),
	}
}

func (m *mockS3MetaStore) GetLineageFile(ctx context.Context, fileName string) (*coordinatorpb.CollectionLineageFile, error) {
	m.mu.RLock()
	defer m.mu.RUnlock()

	if file, exists := m.lineageFiles[fileName]; exists {
		return file, nil
	}
	return &coordinatorpb.CollectionLineageFile{
		Dependencies: []*coordinatorpb.CollectionVersionDependency{},
	}, nil
}

func (m *mockS3MetaStore) PutLineageFile(ctx context.Context, tenantID, databaseID, collectionID, fileName string, file *coordinatorpb.CollectionLineageFile) (string, error) {
	m.mu.Lock()
	defer m.mu.Unlock()

	m.lineageFiles[fileName] = file
	return fileName, nil
}

func (m *mockS3MetaStore) GetVersionFile(ctx context.Context, fileName string) (*coordinatorpb.CollectionVersionFile, error) {
	m.mu.RLock()
	defer m.mu.RUnlock()

	if file, exists := m.versionFiles[fileName]; exists {
		return file, nil
	}
	return &coordinatorpb.CollectionVersionFile{
		VersionHistory: &coordinatorpb.CollectionVersionHistory{
			Versions: []*coordinatorpb.CollectionVersionInfo{},
		},
	}, nil
}

func (m *mockS3MetaStore) ListVersionFiles() ([]*coordinatorpb.CollectionVersionFile, []string, error) {
	m.mu.RLock()
	defer m.mu.RUnlock()

	var files []*coordinatorpb.CollectionVersionFile
	var names []string
	for fileName, file := range m.versionFiles {
		names = append(names, fileName)
		files = append(files, file)
	}
	return files, names, nil
}

func (m *mockS3MetaStore) PutVersionFile(ctx context.Context, tenantID, databaseID, collectionID, fileName string, file *coordinatorpb.CollectionVersionFile) (string, error) {
	m.mu.Lock()
	defer m.mu.Unlock()

	m.versionFiles[fileName] = file
	return fileName, nil
}

func (m *mockS3MetaStore) HasObjectWithPrefix(ctx context.Context, prefix string) (bool, error) {
	return false, nil
}

func (m *mockS3MetaStore) DeleteVersionFile(ctx context.Context, tenantID, databaseID, collectionID, fileName string) error {
	m.mu.Lock()
	defer m.mu.Unlock()

	delete(m.versionFiles, fileName)
	return nil
}

func TestCatalog_FlushCollectionCompactionForVersionedCollection(t *testing.T) {
	// Create mocks
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}
	mockTenantDb := &mocks.ITenantDb{}
	mockSegmentDb := &mocks.ISegmentDb{}
	mockS3Store := newMockS3MetaStore()

	// Create catalog with version file enabled
	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, mockS3Store, true)

	// Test data
	collectionID := types.MustParse("00000000-0000-0000-0000-000000000001")
	tenantID := "test_tenant"
	currentVersion := int32(1)
	logPosition := int64(100)
	dbId := "00000000-0000-0000-0000-000000000002"

	version1FilePath := map[string]*coordinatorpb.FilePaths{
		"test_path": {
			Paths: []string{"test_file"},
		},
	}

	// Set up initial version file that would have been created by CreateCollection
	initialVersionFile := &coordinatorpb.CollectionVersionFile{
		CollectionInfoImmutable: &coordinatorpb.CollectionInfoImmutable{
			CollectionId: collectionID.String(),
		},
		VersionHistory: &coordinatorpb.CollectionVersionHistory{
			Versions: []*coordinatorpb.CollectionVersionInfo{
				{
					Version: 1,
					SegmentInfo: &coordinatorpb.CollectionSegmentInfo{
						SegmentCompactionInfo: []*coordinatorpb.FlushSegmentCompactionInfo{
							{
								FilePaths: version1FilePath,
							},
						},
					},
				},
			},
		},
	}
	fileName, err := mockS3Store.PutVersionFile(context.Background(), tenantID, "test_database", collectionID.String(), "version_1.pb", initialVersionFile)
	assert.NoError(t, err)
	assert.Equal(t, "version_1.pb", fileName)

	collectionName := "test_collection"
	configurationJson := "{test_config}"
	schemaJson := "{test_schema}"
	dim := int32(128)

	mockCollectionsAndMetadata := []*dbmodel.CollectionAndMetadata{
		{
			// Fill all the fields with necessary data
			Collection: &dbmodel.Collection{
				ID:                         collectionID.String(),
				Name:                       &collectionName,
				ConfigurationJsonStr:       &configurationJson,
				SchemaStr:                  &schemaJson,
				Dimension:                  &dim,
				DatabaseID:                 dbId,
				Ts:                         types.Timestamp(0),
				IsDeleted:                  false,
				CreatedAt:                  time.Now(),
				UpdatedAt:                  time.Now(),
				LogPosition:                10,
				Version:                    int32(currentVersion),
				VersionFileName:            "version_1.pb",
				RootCollectionId:           nil,
				LineageFileName:            nil,
				TotalRecordsPostCompaction: 10,
				SizeBytesPostCompaction:    100,
				LastCompactionTimeSecs:     0,
				NumVersions:                1,
				OldestVersionTs:            time.Now(),
				Tenant:                     tenantID,
			},
			CollectionMetadata: []*dbmodel.CollectionMetadata{},
			TenantID:           tenantID,
			DatabaseName:       "test_database",
		},
	}

	collectionIdStr := collectionID.String()
	mockSegments := []*dbmodel.SegmentAndMetadata{
		{
			Segment: &dbmodel.Segment{
				CollectionID: &collectionIdStr,
				ID:           "00000000-0000-0000-0000-000000000003",
				Type:         "test_type",
				Scope:        "test_scope",
				Ts:           types.Timestamp(0),
				IsDeleted:    false,
				CreatedAt:    time.Now(),
				UpdatedAt:    time.Now(),
				FilePaths: map[string][]string{
					"test_path": {"test_file"},
				},
			},
			SegmentMetadata: []*dbmodel.SegmentMetadata{},
		},
	}

	// Setup mock behaviors
	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockMetaDomain.On("TenantDb", mock.Anything).Return(mockTenantDb)
	mockMetaDomain.On("SegmentDb", mock.Anything).Return(mockSegmentDb)

	mockCollectionDb.On("GetCollectionEntries", types.FromUniqueID(collectionID), mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(mockCollectionsAndMetadata, nil)
	mockSegmentDb.On("GetSegments", mock.Anything, mock.Anything, mock.Anything, collectionID).Return(mockSegments, nil)
	mockCollectionDb.On("UpdateLogPositionAndVersionInfo",
		collectionID.String(),
		logPosition,
		currentVersion,
		"version_1.pb",
		currentVersion+1,
		mock.Anything,
		uint64(1),
		uint64(1),
		mock.Anything,
		mock.Anything,
		mock.Anything,
	).Return(int64(1), nil)

	mockTenantDb.On("UpdateTenantLastCompactionTime", tenantID, mock.Anything).Return(nil)
	mockSegmentDb.On("RegisterFilePaths", mock.Anything).Return(nil)

	mockTxImpl.On("Transaction", mock.Anything, mock.Anything).Run(func(args mock.Arguments) {
		fn := args.Get(1).(func(context.Context) error)
		fn(context.Background())
	}).Return(nil)

	segmentIdStr := "00000000-0000-0000-0000-000000000004"
	segmentId, _ := types.ToUniqueID(&segmentIdStr)
	flushSegment := []*model.FlushSegmentCompaction{
		{
			ID: segmentId,
			FilePaths: map[string][]string{
				"test_path2": {"test_file2"},
			},
		},
	}

	// Create test input
	flushRequest := &model.FlushCollectionCompaction{
		ID:                         collectionID,
		TenantID:                   tenantID,
		CurrentCollectionVersion:   currentVersion,
		LogPosition:                logPosition,
		FlushSegmentCompactions:    flushSegment,
		TotalRecordsPostCompaction: 1,
		SizeBytesPostCompaction:    1,
		SchemaStr:                  func() *string { s := "{}"; return &s }(),
	}

	// Execute test
	result, err := catalog.FlushCollectionCompaction(context.Background(), flushRequest)

	// Verify results
	assert.NoError(t, err)
	assert.NotNil(t, result)
	assert.Equal(t, collectionID.String(), result.ID)
	assert.Equal(t, currentVersion+1, result.CollectionVersion)
	assert.Greater(t, result.TenantLastCompactionTime, int64(0))

	// Verify mock expectations
	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
	mockTenantDb.AssertExpectations(t)
	mockSegmentDb.AssertExpectations(t)

	// Verify S3 store has the new version file
	assert.Greater(t, len(mockS3Store.versionFiles), 0)

	// Verify the contents of the s3 file.
	versionFiles, fileNames, err := mockS3Store.ListVersionFiles()
	assert.NoError(t, err)

	assert.Equal(t, 2, len(versionFiles))
	var index = -1
	for i, name := range fileNames {
		if name != "version_1.pb" {
			index = i
			break
		}
	}
	assert.Greater(t, index, -1)
	fileToValidate := versionFiles[index]
	version2FilePath := map[string]*coordinatorpb.FilePaths{
		"test_path2": {
			Paths: []string{"test_file2"},
		},
	}
	for _, version := range fileToValidate.VersionHistory.Versions {
		if version.Version == 2 {
			// assert that segment info is set to test_path2
			assert.Equal(t, version2FilePath, version.SegmentInfo.SegmentCompactionInfo[0].FilePaths)
		} else if version.Version == 1 {
			// assert that segment info is set to test_path
			assert.Equal(t, version1FilePath, version.SegmentInfo.SegmentCompactionInfo[0].FilePaths)
		} else {
			assert.Fail(t, "Unexpected version found")
		}
	}
}

func TestCatalog_FlushCollectionCompactionForVersionedCollectionWithEmptyFilePaths(t *testing.T) {
	// Create mocks
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}
	mockTenantDb := &mocks.ITenantDb{}
	mockSegmentDb := &mocks.ISegmentDb{}
	mockS3Store := newMockS3MetaStore()

	// Create catalog with version file enabled
	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, mockS3Store, true)

	// Test data
	collectionID := types.MustParse("00000000-0000-0000-0000-000000000001")
	tenantID := "test_tenant"
	currentVersion := int32(1)
	logPosition := int64(100)
	dbId := "00000000-0000-0000-0000-000000000002"

	version1FilePath := map[string]*coordinatorpb.FilePaths{
		"test_path": {
			Paths: []string{"test_file"},
		},
	}

	// Set up initial version file that would have been created by CreateCollection
	initialVersionFile := &coordinatorpb.CollectionVersionFile{
		CollectionInfoImmutable: &coordinatorpb.CollectionInfoImmutable{
			CollectionId: collectionID.String(),
		},
		VersionHistory: &coordinatorpb.CollectionVersionHistory{
			Versions: []*coordinatorpb.CollectionVersionInfo{
				{
					Version: 1,
					SegmentInfo: &coordinatorpb.CollectionSegmentInfo{
						SegmentCompactionInfo: []*coordinatorpb.FlushSegmentCompactionInfo{
							{
								FilePaths: version1FilePath,
							},
						},
					},
				},
			},
		},
	}
	fileName, err := mockS3Store.PutVersionFile(context.Background(), tenantID, "test_database", collectionID.String(), "version_1.pb", initialVersionFile)
	assert.NoError(t, err)
	assert.Equal(t, "version_1.pb", fileName)

	collectionName := "test_collection"
	configurationJson := "{test_config}"
	schemaJson := "{test_schema}"
	dim := int32(128)

	mockCollectionsAndMetadata := []*dbmodel.CollectionAndMetadata{
		{
			// Fill all the fields with necessary data
			Collection: &dbmodel.Collection{
				ID:                         collectionID.String(),
				Name:                       &collectionName,
				ConfigurationJsonStr:       &configurationJson,
				SchemaStr:                  &schemaJson,
				Dimension:                  &dim,
				DatabaseID:                 dbId,
				Ts:                         types.Timestamp(0),
				IsDeleted:                  false,
				CreatedAt:                  time.Now(),
				UpdatedAt:                  time.Now(),
				LogPosition:                10,
				Version:                    int32(currentVersion),
				VersionFileName:            "version_1.pb",
				RootCollectionId:           nil,
				LineageFileName:            nil,
				TotalRecordsPostCompaction: 10,
				SizeBytesPostCompaction:    100,
				LastCompactionTimeSecs:     0,
				NumVersions:                1,
				OldestVersionTs:            time.Now(),
				Tenant:                     tenantID,
			},
			CollectionMetadata: []*dbmodel.CollectionMetadata{},
			TenantID:           tenantID,
			DatabaseName:       "test_database",
		},
	}

	collectionIdStr := collectionID.String()
	mockSegments := []*dbmodel.SegmentAndMetadata{
		{
			Segment: &dbmodel.Segment{
				CollectionID: &collectionIdStr,
				ID:           "00000000-0000-0000-0000-000000000003",
				Type:         "test_type",
				Scope:        "test_scope",
				Ts:           types.Timestamp(0),
				IsDeleted:    false,
				CreatedAt:    time.Now(),
				UpdatedAt:    time.Now(),
				FilePaths: map[string][]string{
					"test_path": {"test_file"},
				},
			},
			SegmentMetadata: []*dbmodel.SegmentMetadata{},
		},
	}

	// Setup mock behaviors
	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockMetaDomain.On("TenantDb", mock.Anything).Return(mockTenantDb)
	mockMetaDomain.On("SegmentDb", mock.Anything).Return(mockSegmentDb)

	mockCollectionDb.On("GetCollectionEntries", types.FromUniqueID(collectionID), mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(mockCollectionsAndMetadata, nil)
	mockSegmentDb.On("GetSegments", mock.Anything, mock.Anything, mock.Anything, collectionID).Return(mockSegments, nil)
	mockCollectionDb.On("UpdateLogPositionAndVersionInfo",
		collectionID.String(),
		logPosition,
		currentVersion,
		"version_1.pb",
		currentVersion+1,
		mock.Anything,
		uint64(1),
		uint64(1),
		mock.Anything,
		mock.Anything,
		mock.Anything,
	).Return(int64(1), nil)

	mockTenantDb.On("UpdateTenantLastCompactionTime", tenantID, mock.Anything).Return(nil)
	mockSegmentDb.On("RegisterFilePaths", mock.Anything).Return(nil)

	mockTxImpl.On("Transaction", mock.Anything, mock.Anything).Run(func(args mock.Arguments) {
		fn := args.Get(1).(func(context.Context) error)
		fn(context.Background())
	}).Return(nil)

	// Flush segment with empty file paths
	flushSegment := []*model.FlushSegmentCompaction{}

	// Create test input
	flushRequest := &model.FlushCollectionCompaction{
		ID:                         collectionID,
		TenantID:                   tenantID,
		CurrentCollectionVersion:   currentVersion,
		LogPosition:                logPosition,
		FlushSegmentCompactions:    flushSegment,
		TotalRecordsPostCompaction: 1,
		SizeBytesPostCompaction:    1,
		SchemaStr:                  func() *string { s := "{}"; return &s }(),
	}

	// Execute test
	result, err := catalog.FlushCollectionCompaction(context.Background(), flushRequest)

	// Verify results
	assert.NoError(t, err)
	assert.NotNil(t, result)
	assert.Equal(t, collectionID.String(), result.ID)
	assert.Equal(t, currentVersion+1, result.CollectionVersion)
	assert.Greater(t, result.TenantLastCompactionTime, int64(0))

	// Verify mock expectations
	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
	mockTenantDb.AssertExpectations(t)
	mockSegmentDb.AssertExpectations(t)

	// Verify S3 store has the new version file
	assert.Greater(t, len(mockS3Store.versionFiles), 0)

	// Verify the contents of the s3 file.
	versionFiles, fileNames, err := mockS3Store.ListVersionFiles()
	assert.NoError(t, err)

	assert.Equal(t, 2, len(versionFiles))
	var index = -1
	for i, name := range fileNames {
		if name != "version_1.pb" {
			index = i
			break
		}
	}
	assert.Greater(t, index, -1)
	fileToValidate := versionFiles[index]
	for _, version := range fileToValidate.VersionHistory.Versions {
		if version.Version == 2 {
			// assert that segment info is set to test_path2
			assert.Equal(t, version1FilePath, version.SegmentInfo.SegmentCompactionInfo[0].FilePaths)
		} else if version.Version == 1 {
			// assert that segment info is set to test_path
			assert.Equal(t, version1FilePath, version.SegmentInfo.SegmentCompactionInfo[0].FilePaths)
		} else {
			assert.Fail(t, "Unexpected version found")
		}
	}
}

func TestCatalog_DeleteCollectionVersion(t *testing.T) {
	// Create mocks
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}
	mockS3Store := newMockS3MetaStore()

	// Create catalog with version file enabled
	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, mockS3Store, true)

	// Test data
	tenantID := "test_tenant"
	databaseID := "test_database"
	collectionID := "00000000-0000-0000-0000-000000000001"
	versions_to_delete := []int64{3}
	currentVersion := int32(3)
	existingVersionFileName := "3_existing_version"

	// Setup initial version file in S3
	initialVersionFile := &coordinatorpb.CollectionVersionFile{
		CollectionInfoImmutable: &coordinatorpb.CollectionInfoImmutable{
			TenantId:     tenantID,
			CollectionId: collectionID,
		},
		VersionHistory: &coordinatorpb.CollectionVersionHistory{
			Versions: []*coordinatorpb.CollectionVersionInfo{
				{Version: 0, CreatedAtSecs: 0},
				{Version: 1, CreatedAtSecs: 1000},
				{Version: 2, CreatedAtSecs: 2000},
				{Version: 3, CreatedAtSecs: 3000},
			},
		},
	}
	mockS3Store.PutVersionFile(context.Background(), tenantID, databaseID, collectionID, existingVersionFileName, initialVersionFile)

	// Setup mock collection entry
	mockCollectionEntry := &dbmodel.Collection{
		ID:              collectionID,
		Version:         currentVersion,
		VersionFileName: existingVersionFileName,
		OldestVersionTs: time.Unix(0, 0),
		NumVersions:     4,
	}

	// Setup mock behaviors
	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockCollectionDb.On("GetCollectionWithoutMetadata", &collectionID, mock.Anything, mock.Anything).Return(mockCollectionEntry, nil)
	mockCollectionDb.On("UpdateVersionRelatedFields",
		collectionID,
		existingVersionFileName,
		mock.AnythingOfType("string"),
		mock.AnythingOfType("*time.Time"), // expect any time value
		mock.AnythingOfType("*int"),       // numActiveVersions
	).Return(int64(1), nil)

	// Create test request
	req := &coordinatorpb.DeleteCollectionVersionRequest{
		Versions: []*coordinatorpb.VersionListForCollection{
			{
				TenantId:     tenantID,
				CollectionId: collectionID,
				Versions:     versions_to_delete,
			},
		},
	}

	// Execute test
	resp, err := catalog.DeleteCollectionVersion(context.Background(), req)

	// Verify results
	assert.NoError(t, err)
	assert.NotNil(t, resp)
	assert.True(t, resp.CollectionIdToSuccess[collectionID])

	existingVersionFileName, err = catalog.GetVersionFileNamesForCollection(context.Background(), tenantID, collectionID)
	assert.NoError(t, err)
	// Verify the version file was updated correctly
	updatedFile, err := mockS3Store.GetVersionFile(
		context.Background(),
		existingVersionFileName,
	)
	assert.NoError(t, err)
	assert.Equal(t, 3, len(updatedFile.VersionHistory.Versions))
	assert.Equal(t, int64(0), updatedFile.VersionHistory.Versions[0].Version)
	assert.Equal(t, int64(1), updatedFile.VersionHistory.Versions[1].Version)
	assert.Equal(t, int64(2), updatedFile.VersionHistory.Versions[2].Version)

	// Verify mock expectations
	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
}

func TestCatalog_DeleteCollectionVersion_CollectionNotFound(t *testing.T) {
	// Create mocks
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}
	mockS3Store := newMockS3MetaStore()

	// Create catalog with version file enabled
	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, mockS3Store, true)

	// Test data
	tenantID := "test_tenant"
	collectionID := "00000000-0000-0000-0000-000000000001"
	versions := []int64{1, 2}

	// Setup mock behaviors
	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockCollectionDb.On("GetCollectionWithoutMetadata", &collectionID, mock.Anything, mock.Anything).Return(nil, nil)

	// Create test request
	req := &coordinatorpb.DeleteCollectionVersionRequest{
		Versions: []*coordinatorpb.VersionListForCollection{
			{
				TenantId:     tenantID,
				CollectionId: collectionID,
				Versions:     versions,
			},
		},
	}

	// Execute test
	resp, err := catalog.DeleteCollectionVersion(context.Background(), req)

	// Verify results
	assert.Error(t, err)
	assert.NotNil(t, resp)
	assert.False(t, resp.CollectionIdToSuccess[collectionID])

	// Verify mock expectations
	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
}

func TestCatalog_MarkVersionForDeletion(t *testing.T) {
	// Create mocks
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}
	mockS3Store := newMockS3MetaStore()

	// Create catalog with version file enabled
	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, mockS3Store, true)

	// Test data
	tenantID := "test_tenant"
	databaseID := "test_database"
	collectionID := "00000000-0000-0000-0000-000000000001"
	versions := []int64{1, 2}
	currentVersion := int32(3)
	existingVersionFileName := "3_existing_version"

	// Setup initial version file in S3
	initialVersionFile := &coordinatorpb.CollectionVersionFile{
		CollectionInfoImmutable: &coordinatorpb.CollectionInfoImmutable{
			TenantId:     tenantID,
			CollectionId: collectionID,
		},
		VersionHistory: &coordinatorpb.CollectionVersionHistory{
			Versions: []*coordinatorpb.CollectionVersionInfo{
				{Version: 1, CreatedAtSecs: 1000},
				{Version: 2, CreatedAtSecs: 2000},
				{Version: 3, CreatedAtSecs: 3000},
			},
		},
	}
	mockS3Store.PutVersionFile(context.Background(), tenantID, databaseID, collectionID, existingVersionFileName, initialVersionFile)

	// Setup mock collection entry
	mockCollectionEntry := &dbmodel.Collection{
		ID:              collectionID,
		Version:         currentVersion,
		VersionFileName: existingVersionFileName,
	}

	// Setup mock behaviors
	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockCollectionDb.On("GetCollectionWithoutMetadata", &collectionID, mock.Anything, mock.Anything).Return(mockCollectionEntry, nil)
	mockCollectionDb.On("UpdateVersionRelatedFields",
		collectionID,
		existingVersionFileName,
		mock.AnythingOfType("string"),
		(*time.Time)(nil),           // oldestVersionTs
		mock.AnythingOfType("*int"), // numActiveVersions
	).Return(int64(1), nil)

	// Create test request
	req := &coordinatorpb.MarkVersionForDeletionRequest{
		Versions: []*coordinatorpb.VersionListForCollection{
			{
				TenantId:     tenantID,
				CollectionId: collectionID,
				Versions:     versions,
			},
		},
	}

	// Execute test
	resp, err := catalog.MarkVersionForDeletion(context.Background(), req)

	// Verify results
	assert.NoError(t, err)
	assert.NotNil(t, resp)
	assert.True(t, resp.CollectionIdToSuccess[collectionID])

	// Verify the version file was updated correctly
	existingVersionFileName, err = catalog.GetVersionFileNamesForCollection(context.Background(), tenantID, collectionID)
	assert.NoError(t, err)
	updatedFile, err := mockS3Store.GetVersionFile(
		context.Background(),
		existingVersionFileName,
	)
	assert.NoError(t, err)

	// Verify versions are marked for deletion
	markedVersions := 0
	for _, version := range updatedFile.VersionHistory.Versions {
		if version.MarkedForDeletion {
			markedVersions++
		}
	}
	assert.Equal(t, 2, markedVersions)

	// Verify mock expectations
	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
}

func TestCatalog_MarkVersionForDeletion_CollectionNotFound(t *testing.T) {
	// Create mocks
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}
	mockS3Store := newMockS3MetaStore()

	// Create catalog with version file enabled
	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, mockS3Store, true)

	// Test data
	tenantID := "test_tenant"
	collectionID := "00000000-0000-0000-0000-000000000001"
	versions := []int64{1, 2}

	// Setup mock behaviors
	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockCollectionDb.On("GetCollectionWithoutMetadata", &collectionID, mock.Anything, mock.Anything).Return(nil, nil)

	// Create test request
	req := &coordinatorpb.MarkVersionForDeletionRequest{
		Versions: []*coordinatorpb.VersionListForCollection{
			{
				TenantId:     tenantID,
				CollectionId: collectionID,
				Versions:     versions,
			},
		},
	}

	// Execute test
	resp, err := catalog.MarkVersionForDeletion(context.Background(), req)

	// Verify results
	assert.NoError(t, err)
	assert.NotNil(t, resp)
	assert.False(t, resp.CollectionIdToSuccess[collectionID])

	// Verify mock expectations
	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
}

func TestCatalog_MarkVersionForDeletion_VersionNotFound(t *testing.T) {
	// Create mocks
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}
	mockS3Store := newMockS3MetaStore()

	// Create catalog with version file enabled
	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, mockS3Store, true)

	// Test data
	tenantID := "test_tenant"
	collectionID := "00000000-0000-0000-0000-000000000001"
	versions := []int64{4, 5} // Versions that don't exist
	currentVersion := int32(3)
	existingVersionFileName := "3_existing_version"

	// Setup initial version file in S3
	initialVersionFile := &coordinatorpb.CollectionVersionFile{
		CollectionInfoImmutable: &coordinatorpb.CollectionInfoImmutable{
			TenantId:     tenantID,
			CollectionId: collectionID,
		},
		VersionHistory: &coordinatorpb.CollectionVersionHistory{
			Versions: []*coordinatorpb.CollectionVersionInfo{
				{Version: 1, CreatedAtSecs: 1000},
				{Version: 2, CreatedAtSecs: 2000},
				{Version: 3, CreatedAtSecs: 3000},
			},
		},
	}
	mockS3Store.PutVersionFile(context.Background(), tenantID, "test_database", collectionID, existingVersionFileName, initialVersionFile)

	// Setup mock collection entry
	mockCollectionEntry := &dbmodel.Collection{
		ID:              collectionID,
		Version:         currentVersion,
		VersionFileName: existingVersionFileName,
	}

	// Setup mock behaviors
	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockCollectionDb.On("GetCollectionWithoutMetadata", &collectionID, mock.Anything, mock.Anything).Return(mockCollectionEntry, nil)

	// Create test request
	req := &coordinatorpb.MarkVersionForDeletionRequest{
		Versions: []*coordinatorpb.VersionListForCollection{
			{
				TenantId:     tenantID,
				CollectionId: collectionID,
				Versions:     versions,
			},
		},
	}

	// Execute test
	resp, err := catalog.MarkVersionForDeletion(context.Background(), req)

	// Verify results
	assert.NoError(t, err)
	assert.NotNil(t, resp)
	assert.False(t, resp.CollectionIdToSuccess[collectionID])

	// Verify mock expectations
	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
}

func TestCatalog_ListCollectionsToGc(t *testing.T) {
	// Create mocks
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}
	mockS3Store := newMockS3MetaStore()

	// Create catalog
	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, mockS3Store, true)

	// Test data
	cutoffTimeSecs := uint64(time.Now().Add(-24 * time.Hour).Unix()) // 24 hours ago
	limit := uint64(10)

	// Mock collections to return
	lineageFileName := "lineage_file_1"
	collectionsToGc := []*dbmodel.CollectionToGc{
		{
			ID:              "00000000-0000-0000-0000-000000000001",
			Name:            "collection1",
			VersionFileName: "3_existing_version",
			OldestVersionTs: time.Now().Add(-48 * time.Hour), // 48 hours ago
		},
		{
			ID:              "00000000-0000-0000-0000-000000000002",
			Name:            "collection2",
			VersionFileName: "2_existing_version",
			OldestVersionTs: time.Now().Add(-36 * time.Hour), // 36 hours ago
			LineageFileName: &lineageFileName,
		},
	}

	// Setup mock behaviors
	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockCollectionDb.On("ListCollectionsToGc", &cutoffTimeSecs, &limit, (*string)(nil), (*uint64)(nil)).Return(collectionsToGc, nil)

	// Execute test
	result, err := catalog.ListCollectionsToGc(context.Background(), &cutoffTimeSecs, &limit, nil, nil)

	// Verify results
	assert.NoError(t, err)
	assert.NotNil(t, result)
	assert.Equal(t, 2, len(result))

	// Verify first collection
	assert.Equal(t, "00000000-0000-0000-0000-000000000001", result[0].ID.String())
	assert.Equal(t, "collection1", result[0].Name)
	assert.Equal(t, "3_existing_version", result[0].VersionFilePath)

	// Verify second collection
	assert.Equal(t, "00000000-0000-0000-0000-000000000002", result[1].ID.String())
	assert.Equal(t, "collection2", result[1].Name)
	assert.Equal(t, "2_existing_version", result[1].VersionFilePath)
	assert.Equal(t, "lineage_file_1", *result[1].LineageFilePath)

	// Verify mock expectations
	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
}

func TestCatalog_ListCollectionsToGc_NilParameters(t *testing.T) {
	// Create mocks
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockCollectionDb := &mocks.ICollectionDb{}
	mockS3Store := newMockS3MetaStore()

	// Create catalog
	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, mockS3Store, true)

	// Mock collections to return
	collectionsToGc := []*dbmodel.CollectionToGc{
		{
			ID:              "00000000-0000-0000-0000-000000000001",
			Name:            "collection1",
			VersionFileName: "3_existing_version",
			OldestVersionTs: time.Now().Add(-48 * time.Hour),
		},
	}

	// Setup mock behaviors
	mockMetaDomain.On("CollectionDb", mock.Anything).Return(mockCollectionDb)
	mockCollectionDb.On("ListCollectionsToGc", (*uint64)(nil), (*uint64)(nil), (*string)(nil), (*uint64)(nil)).Return(collectionsToGc, nil)

	// Execute test with nil parameters
	result, err := catalog.ListCollectionsToGc(context.Background(), nil, nil, nil, nil)

	// Verify results
	assert.NoError(t, err)
	assert.NotNil(t, result)
	assert.Equal(t, 1, len(result))

	// Verify collection details
	assert.Equal(t, "00000000-0000-0000-0000-000000000001", result[0].ID.String())
	assert.Equal(t, "collection1", result[0].Name)
	assert.Equal(t, "3_existing_version", result[0].VersionFilePath)

	// Verify mock expectations
	mockMetaDomain.AssertExpectations(t)
	mockCollectionDb.AssertExpectations(t)
}

func TestUpdateCollectionConfiguration(t *testing.T) {
	// Create a new catalog instance
	catalog := NewTableCatalog(nil, nil, nil, false)

	tests := []struct {
		name                            string
		existingConfigJson              *string
		updateConfigJson                *string
		collectionMetadata              []*dbmodel.CollectionMetadata
		expectedError                   bool
		expectedHnswConfig              *model.HnswConfiguration
		expectedSpannConfig             *model.SpannConfiguration
		expectedEmbeddingFunctionConfig *model.EmbeddingFunctionConfiguration
	}{
		{
			name: "Update HNSW configuration",
			existingConfigJson: strPtr(`{
				"vector_index": {
					"hnsw": {
						"space": "l2",
						"ef_construction": 100,
						"ef_search": 100,
						"max_neighbors": 16,
						"num_threads": 16,
						"resize_factor": 1.2,
						"batch_size": 100,
						"sync_threshold": 1000
					}
				}
			}`),
			updateConfigJson: strPtr(`{
				"vector_index": {
					"hnsw": {
						"ef_search": 20,
						"num_threads": 4
					}
				}
			}`),
			expectedHnswConfig: &model.HnswConfiguration{
				Space:          "l2",
				EfConstruction: 100,
				EfSearch:       20,
				MaxNeighbors:   16,
				NumThreads:     4,
				ResizeFactor:   1.2,
				BatchSize:      100,
				SyncThreshold:  1000,
			},
		},
		{
			name:               "Update from legacy metadata",
			existingConfigJson: nil,
			collectionMetadata: []*dbmodel.CollectionMetadata{
				{
					Key:      strPtr("hnsw:ef"),
					IntValue: int64Ptr(50),
				},
				{
					Key:      strPtr("hnsw:num_threads"),
					IntValue: int64Ptr(8),
				},
				{
					Key:        strPtr("hnsw:resize_factor"),
					FloatValue: float64Ptr(1.2),
				},
				{
					Key:      strPtr("hnsw:batch_size"),
					IntValue: int64Ptr(100),
				},
				{
					Key:      strPtr("hnsw:sync_threshold"),
					IntValue: int64Ptr(1000),
				},
			},
			updateConfigJson: strPtr(`{
				"vector_index": {
					"hnsw": {
						"ef_search": 20
					}
				}
			}`),
			expectedHnswConfig: &model.HnswConfiguration{
				Space:          "l2",
				EfConstruction: 100,
				EfSearch:       20,
				MaxNeighbors:   16,
				NumThreads:     8,
				ResizeFactor:   1.2,
				BatchSize:      100,
				SyncThreshold:  1000,
			},
		},
		{
			name: "Update SPANN configuration",
			existingConfigJson: strPtr(`{
				"vector_index": {
					"spann": {
						"search_nprobe": 10,
						"write_nprobe": 5,
						"space": "l2",
						"ef_construction": 100,
						"ef_search": 50,
						"max_neighbors": 16
					}
				}
			}`),
			updateConfigJson: strPtr(`{
				"vector_index": {
					"spann": {
						"ef_search": 75,
						"search_nprobe": 15
					}
				}
			}`),
			expectedSpannConfig: &model.SpannConfiguration{
				SearchNprobe:   15, // Updated
				WriteNprobe:    5,
				Space:          "l2",
				EfConstruction: 100,
				EfSearch:       75, // Updated
				MaxNeighbors:   16,
			},
		},
		{
			name: "Convert from HNSW to SPANN",
			existingConfigJson: strPtr(`{
				"vector_index": {
					"hnsw": {
						"space": "l2",
						"ef_construction": 100,
						"ef_search": 100,
						"max_neighbors": 16,
						"num_threads": 16,
						"resize_factor": 1.2,
						"batch_size": 100,
						"sync_threshold": 1000
					}
				}
			}`),
			updateConfigJson: strPtr(`{
				"vector_index": {
					"spann": {
						"search_nprobe": 10,
						"write_nprobe": 5,
						"space": "l2",
						"ef_construction": 100,
						"ef_search": 50,
						"max_neighbors": 16
					}
				}
			}`),
			// Expect the original HNSW config because type change is ignored
			expectedHnswConfig: &model.HnswConfiguration{
				Space:          "l2",
				EfConstruction: 100,
				EfSearch:       100,
				MaxNeighbors:   16,
				NumThreads:     16,
				ResizeFactor:   1.2,
				BatchSize:      100,
				SyncThreshold:  1000,
			},
		},
		{
			name: "Convert from SPANN to HNSW",
			existingConfigJson: strPtr(`{
				"vector_index": {
					"spann": {
						"search_nprobe": 10,
						"write_nprobe": 5,
						"space": "l2",
						"ef_construction": 100,
						"ef_search": 50,
						"max_neighbors": 16
					}
				}
			}`),
			updateConfigJson: strPtr(`{
				"vector_index": {
					"hnsw": {
						"ef_search": 20,
						"num_threads": 4
					}
				}
			}`),
			// Expect the original SPANN config because type change is ignored
			expectedSpannConfig: &model.SpannConfiguration{
				SearchNprobe:   10,
				WriteNprobe:    5,
				Space:          "l2",
				EfConstruction: 100,
				EfSearch:       50,
				MaxNeighbors:   16, // Corresponds to 'max_neighbors' in the input JSON
			},
		},
		{
			name: "Invalid update configuration JSON",
			existingConfigJson: strPtr(`{
				"vector_index": {
					"hnsw": {
						"space": "l2",
						"ef_construction": 100,
						"ef_search": 100,
						"max_neighbors": 16,
						"num_threads": 16,
						"resize_factor": 1.2,
						"batch_size": 100,
						"sync_threshold": 1000
					}
				}
			}`),
			updateConfigJson: strPtr(`{invalid json`),
			expectedError:    true,
		},
		{
			name: "Update embedding function configuration",
			existingConfigJson: strPtr(`{
				"embedding_function": {
					"type": "known",
					"name": "test",
					"config": {}
				}
			}`),
			updateConfigJson: strPtr(`{
				"embedding_function": {
					"type": "known",
					"name": "test2",
					"config": {
						"test": "test"
					}
				}
			}`),
			expectedEmbeddingFunctionConfig: &model.EmbeddingFunctionConfiguration{
				Name: "test2",
				Config: map[string]any{
					"test": "test",
				},
				Type: "known",
			},
		},
		{
			name: "Update embedding function configuration with spann",
			existingConfigJson: strPtr(`{
				"vector_index": {
					"spann": {
						"search_nprobe": 10,
						"write_nprobe": 5,
						"space": "l2",
						"ef_construction": 100,
						"ef_search": 50,
						"max_neighbors": 16
					}
				},
				"embedding_function": {
					"type": "known",
					"name": "test",
					"config": {}
				}
			}`),
			updateConfigJson: strPtr(`{
				"vector_index": {
					"spann": {
						"ef_search": 75,
						"search_nprobe": 15
					}
				},
				"embedding_function": {
					"type": "known",
					"name": "test2",
					"config": {
						"test": "test"
					}
				}
			}`),
			expectedEmbeddingFunctionConfig: &model.EmbeddingFunctionConfiguration{
				Name: "test2",
				Config: map[string]any{
					"test": "test",
				},
				Type: "known",
			},
			expectedSpannConfig: &model.SpannConfiguration{
				SearchNprobe:   15,
				WriteNprobe:    5,
				Space:          "l2",
				EfConstruction: 100,
				EfSearch:       75,
				MaxNeighbors:   16,
			},
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			result, err := catalog.updateCollectionConfiguration(
				tt.existingConfigJson,
				tt.updateConfigJson,
				tt.collectionMetadata,
			)

			if tt.expectedError {
				assert.Error(t, err)
				return
			}

			assert.NoError(t, err)
			assert.NotNil(t, result)

			// Parse the result to verify the configuration
			var config model.InternalCollectionConfiguration
			err = json.Unmarshal([]byte(*result), &config)
			assert.NoError(t, err)

			if tt.expectedHnswConfig != nil {
				assert.Equal(t, tt.expectedHnswConfig, config.VectorIndex.Hnsw)
			}

			if tt.expectedSpannConfig != nil {
				assert.Equal(t, tt.expectedSpannConfig, config.VectorIndex.Spann)
			}
		})
	}
}

// Helper functions
func strPtr(s string) *string {
	return &s
}

func int64Ptr(i int64) *int64 {
	return &i
}

func float64Ptr(f float64) *float64 {
	return &f
}

func TestCatalog_SetTenantResourceName(t *testing.T) {
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockTenantDb := &mocks.ITenantDb{}

	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, nil, false)

	tenantID := "test_tenant"
	resourceName := "static_tenant_name"

	mockMetaDomain.On("TenantDb", mock.Anything).Return(mockTenantDb)
	mockTenantDb.On("SetTenantResourceName", tenantID, resourceName).Return(nil)

	err := catalog.SetTenantResourceName(context.Background(), tenantID, resourceName)

	assert.NoError(t, err)

	mockMetaDomain.AssertExpectations(t)
	mockTenantDb.AssertExpectations(t)
}

func TestCatalog_SetTenantResourceName_TenantNotFound(t *testing.T) {
	mockTxImpl := &mocks.ITransaction{}
	mockMetaDomain := &mocks.IMetaDomain{}
	mockTenantDb := &mocks.ITenantDb{}

	catalog := NewTableCatalog(mockTxImpl, mockMetaDomain, nil, false)

	tenantID := "non_existent_tenant"
	resourceName := "static_tenant_name"

	mockMetaDomain.On("TenantDb", mock.Anything).Return(mockTenantDb)
	mockTenantDb.On("SetTenantResourceName", tenantID, resourceName).Return(common.ErrTenantNotFound)

	err := catalog.SetTenantResourceName(context.Background(), tenantID, resourceName)

	assert.Error(t, err)
	assert.Equal(t, common.ErrTenantNotFound, err)

	mockMetaDomain.AssertExpectations(t)
	mockTenantDb.AssertExpectations(t)
}
