/*
Copyright 2015 The Kubernetes Authors.
Copyright 2020 Authors of Arktos - file modified.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package endpoints

import (
	"reflect"
	"testing"

	"github.com/davecgh/go-spew/spew"
	"k8s.io/apimachinery/pkg/types"
	api "k8s.io/kubernetes/pkg/apis/core"
)

func podRef(uid string) *api.ObjectReference {
	ref := api.ObjectReference{UID: types.UID(uid)}
	return &ref
}

func TestPackSubsetsOneServiceGroup(t *testing.T) {
	// The downside of table-driven tests is that some things have to live outside the table.
	fooObjRef := api.ObjectReference{Name: "foo"}
	barObjRef := api.ObjectReference{Name: "bar"}

	testCases := []struct {
		name   string
		given  []api.EndpointSubset
		expect []api.EndpointSubset
	}{
		{
			name:   "empty everything",
			given:  []api.EndpointSubset{{Addresses: []api.EndpointAddress{}, Ports: []api.EndpointPort{}}},
			expect: []api.EndpointSubset{},
		}, {
			name:   "empty addresses",
			given:  []api.EndpointSubset{{Addresses: []api.EndpointAddress{}, Ports: []api.EndpointPort{{Port: 111}}}},
			expect: []api.EndpointSubset{},
		}, {
			name:   "empty ports",
			given:  []api.EndpointSubset{{Addresses: []api.EndpointAddress{{IP: "1.2.3.4"}}, Ports: []api.EndpointPort{}, ServiceGroupId: "1"}},
			expect: []api.EndpointSubset{{Addresses: []api.EndpointAddress{{IP: "1.2.3.4"}}, Ports: nil, ServiceGroupId: "1"}},
		}, {
			name:   "empty ports",
			given:  []api.EndpointSubset{{NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4"}}, Ports: []api.EndpointPort{}}},
			expect: []api.EndpointSubset{{NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4"}}, Ports: nil}},
		}, {
			name: "one set, one ip, one port",
			given: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:     []api.EndpointPort{{Port: 111}},
			}},
			expect: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:     []api.EndpointPort{{Port: 111}},
			}},
		}, {
			name: "one set, one ip, one port (IPv6)",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "beef::1:2:3:4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "beef::1:2:3:4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "one set, one notReady ip, one port",
			given: []api.EndpointSubset{{
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
			expect: []api.EndpointSubset{{
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
		}, {
			name: "one set, one ip, one UID, one port",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}},
		}, {
			name: "one set, one notReady ip, one UID, one port",
			given: []api.EndpointSubset{{
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
			expect: []api.EndpointSubset{{
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
		}, {
			name: "one set, one ip, empty UID, one port",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "one set, one notReady ip, empty UID, one port",
			given: []api.EndpointSubset{{
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("")}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
			expect: []api.EndpointSubset{{
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("")}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
		}, {
			name: "one set, two ips, one port",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}, {IP: "5.6.7.8"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}, {IP: "5.6.7.8"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "one set, two mixed ips, one port",
			given: []api.EndpointSubset{{
				Addresses:         []api.EndpointAddress{{IP: "1.2.3.4"}},
				NotReadyAddresses: []api.EndpointAddress{{IP: "5.6.7.8"}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:         []api.EndpointAddress{{IP: "1.2.3.4"}},
				NotReadyAddresses: []api.EndpointAddress{{IP: "5.6.7.8"}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
		}, {
			name: "one set, two duplicate ips, one port, notReady is covered by ready",
			given: []api.EndpointSubset{{
				Addresses:         []api.EndpointAddress{{IP: "1.2.3.4"}},
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "10",
			}},
			expect: []api.EndpointSubset{{
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "10",
			}},
		}, {
			name: "one set, one ip, two ports",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}, {Port: 222}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}, {Port: 222}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "one set, dup ips, one port",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}, {IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "one set, dup ips, one port (IPv6)",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "beef::1"}, {IP: "beef::1"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "beef::1"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "one set, dup ips with target-refs, one port",
			given: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{
					{IP: "1.2.3.4", TargetRef: &fooObjRef},
					{IP: "1.2.3.4", TargetRef: &barObjRef},
				},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: &fooObjRef}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "one set, dup mixed ips with target-refs, one port",
			given: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{
					{IP: "1.2.3.4", TargetRef: &fooObjRef},
				},
				NotReadyAddresses: []api.EndpointAddress{
					{IP: "1.2.3.4", TargetRef: &barObjRef},
				},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				// finding the same address twice is considered an error on input, only the first address+port
				// reference is preserved
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: &fooObjRef}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
		}, {
			name: "one set, one ip, dup ports",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}, {Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "two sets, dup ip, dup port",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "two sets, dup mixed ip, dup port",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
			expect: []api.EndpointSubset{{
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
		}, {
			name: "two sets, dup ip, two ports",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 222}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}, {Port: 222}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "two sets, dup ip, dup uids, two ports",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 222}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}, {Port: 222}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "two sets, dup mixed ip, dup uids, two ports",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:             []api.EndpointPort{{Port: 222}},
				ServiceGroupId:    "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:             []api.EndpointPort{{Port: 222}},
				ServiceGroupId:    "1",
			}},
		}, {
			name: "two sets, two ips, dup port",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "5.6.7.8"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}, {IP: "5.6.7.8"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "two set, dup ip, two uids, dup ports",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-2")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{
					{IP: "1.2.3.4", TargetRef: podRef("uid-1")},
					{IP: "1.2.3.4", TargetRef: podRef("uid-2")},
				},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "two set, dup ip, with and without uid, dup ports",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-2")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{
					{IP: "1.2.3.4"},
					{IP: "1.2.3.4", TargetRef: podRef("uid-2")},
				},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "two sets, two ips, two dup ip with uid, dup port, wrong order",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "5.6.7.8"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "5.6.7.8", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{
					{IP: "1.2.3.4"},
					{IP: "1.2.3.4", TargetRef: podRef("uid-1")},
					{IP: "5.6.7.8"},
					{IP: "5.6.7.8", TargetRef: podRef("uid-1")},
				},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "two sets, two mixed ips, two dup ip with uid, dup port, wrong order, ends up with split addresses",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "5.6.7.8"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				NotReadyAddresses: []api.EndpointAddress{{IP: "5.6.7.8", TargetRef: podRef("uid-1")}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}, {
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}, {
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:             []api.EndpointPort{{Port: 111}},
				ServiceGroupId:    "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{
					{IP: "5.6.7.8"},
				},
				NotReadyAddresses: []api.EndpointAddress{
					{IP: "1.2.3.4"},
					{IP: "1.2.3.4", TargetRef: podRef("uid-1")},
					{IP: "5.6.7.8", TargetRef: podRef("uid-1")},
				},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "two sets, two ips, two ports",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "5.6.7.8"}},
				Ports:          []api.EndpointPort{{Port: 222}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "5.6.7.8"}},
				Ports:          []api.EndpointPort{{Port: 222}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "four sets, three ips, three ports, jumbled",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.5"}},
				Ports:          []api.EndpointPort{{Port: 222}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.6"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.5"}},
				Ports:          []api.EndpointPort{{Port: 333}},
				ServiceGroupId: "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}, {IP: "1.2.3.6"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.5"}},
				Ports:          []api.EndpointPort{{Port: 222}, {Port: 333}},
				ServiceGroupId: "1",
			}},
		}, {
			name: "four sets, three mixed ips, three ports, jumbled",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.5"}},
				Ports:             []api.EndpointPort{{Port: 222}},
				ServiceGroupId:    "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.6"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.5"}},
				Ports:             []api.EndpointPort{{Port: 333}},
				ServiceGroupId:    "1",
			}},
			expect: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}, {IP: "1.2.3.6"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				NotReadyAddresses: []api.EndpointAddress{{IP: "1.2.3.5"}},
				Ports:             []api.EndpointPort{{Port: 222}, {Port: 333}},
				ServiceGroupId:    "1",
			}},
		},
	}

	for _, tc := range testCases {
		result := RepackSubsets(tc.given)
		if !reflect.DeepEqual(result, SortSubsets(tc.expect)) {
			t.Errorf("case %q: expected %s, got %s", tc.name, spew.Sprintf("%#v", SortSubsets(tc.expect)), spew.Sprintf("%#v", result))
		}
	}
}

// Majority of consolidation cases are tested in TestPackSubsetsOneServiceGroup. This test only does selected testcases for muliple service group id
func TestPackSubsetsMultipleServiceGroups(t *testing.T) {
	// The downside of table-driven tests is that some things have to live outside the table.
	testCases := []struct {
		name   string
		given  []api.EndpointSubset
		expect []api.EndpointSubset
	}{
		{
			name:   "empty everything, empty service group id",
			given:  []api.EndpointSubset{{Addresses: []api.EndpointAddress{}, Ports: []api.EndpointPort{}}},
			expect: []api.EndpointSubset{},
		}, {
			name:   "empty addresses, empty service group id",
			given:  []api.EndpointSubset{{Addresses: []api.EndpointAddress{}, Ports: []api.EndpointPort{{Port: 111}}}},
			expect: []api.EndpointSubset{},
		}, {
			name: "no service group ids, two sets, dup ip, two ports",
			given: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:     []api.EndpointPort{{Port: 111}},
			}, {
				Addresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:     []api.EndpointPort{{Port: 222}},
			}},
			expect: []api.EndpointSubset{
				{
					Addresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
					Ports:     []api.EndpointPort{{Port: 111}, {Port: 222}},
				},
			},
		},
		{
			name: "one empty service group id, one non empty service group id, two sets, dup ip, two ports",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}, {
				Addresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:     []api.EndpointPort{{Port: 222}},
			}},
			expect: []api.EndpointSubset{
				{
					Addresses: []api.EndpointAddress{{IP: "1.2.3.4"}},
					Ports:     []api.EndpointPort{{Port: 222}},
				},
				{
					Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
					Ports:          []api.EndpointPort{{Port: 111}},
					ServiceGroupId: "0",
				},
			},
		},
		{
			name: "two service group ids, two sets, two ips, two dup ip with uid, dup port, wrong order 1",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "5.6.7.8"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "5.6.7.8", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}},
			expect: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{
					{IP: "1.2.3.4"},
					{IP: "1.2.3.4", TargetRef: podRef("uid-1")},
					{IP: "5.6.7.8"},
					{IP: "5.6.7.8", TargetRef: podRef("uid-1")},
				},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		},
		{
			name: "two service group ids, two sets, two ips, two dup ip with uid, dup port, wrong order 2",
			given: []api.EndpointSubset{{
				Addresses:      []api.EndpointAddress{{IP: "5.6.7.8"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "5.6.7.8", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4", TargetRef: podRef("uid-1")}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}},
			expect: []api.EndpointSubset{{
				Addresses: []api.EndpointAddress{
					{IP: "1.2.3.4"},
					{IP: "1.2.3.4", TargetRef: podRef("uid-1")},
					{IP: "5.6.7.8"},
					{IP: "5.6.7.8", TargetRef: podRef("uid-1")},
				},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "0",
			}, {
				Addresses:      []api.EndpointAddress{{IP: "1.2.3.4"}},
				Ports:          []api.EndpointPort{{Port: 111}},
				ServiceGroupId: "1",
			}},
		},
	}

	for _, tc := range testCases {
		result := RepackSubsets(tc.given)
		if !reflect.DeepEqual(result, SortSubsets(tc.expect)) {
			t.Errorf("case %q: expected %s, got %s", tc.name, spew.Sprintf("%#v", SortSubsets(tc.expect)), spew.Sprintf("%#v", result))
		}
	}
}
